You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
prefer dataDirectoryName from product-info.json when resolving JetBrains plugin directories
keep the existing product/build-based path derivation as a fallback
add tests covering both the preferred and fallback behaviors
Why
Some JetBrains IDEs use a data directory name that does not match the path derived from productCode + buildNumber. In those cases, the plugin can be installed into the wrong directory.
Testing
cargo test mdm::jetbrains::detection::tests:: -- --nocapture
Thanks for the contribution @peckfly! What behavior/bug is this fixing?
This fixes JetBrains plugin installation/detection on IDEs where the actual config/plugins directory is defined by dataDirectoryName in product-info.json, but the current code derives the directory from productCode + buildNumber.
For example, on IntelliJ IDEA 2026.1, product-info.json reports dataDirectoryName=IntelliJIdea2026.1, while the current logic derives IU2026.1. That causes git-ai to look in / install into the wrong plugins directory, so the plugin may appear missing or not get loaded by the IDE.
This change prefers dataDirectoryName when available, and falls back to the existing productCode + buildNumber behavior otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataDirectoryNamefromproduct-info.jsonwhen resolving JetBrains plugin directoriesWhy
Some JetBrains IDEs use a data directory name that does not match the path derived from
productCode + buildNumber. In those cases, the plugin can be installed into the wrong directory.Testing
cargo test mdm::jetbrains::detection::tests:: -- --nocapturecargo fmt -- --check