Resolve milestone by name on gitea issue Create/Update#77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76.
forge issue create -m <milestone>andforge issue edit <n> -m <milestone>were silent no-ops against Gitea/Forgejo becausegiteaIssueService.CreateandUpdatenever readopts.Milestone. Same class of bug as #75.Unlike labels,
gitea.CreateIssueOptionandgitea.EditIssueOptionalready have aMilestonefield, so this goes through the existing calls rather than a separate endpoint. The SDK providesGetMilestoneByNameso the title-to-ID resolver is a single lookup rather than a paginated scan.Empty string on
Updatesendsmilestone: 0to clear the assignment. An unknown title producesmilestone not found: <name>instead of silently succeeding.The
Updatebranch is placed before the existing labels block so that setting both-land-mtogether still reachesEditIssueafterReplaceIssueLabelsfires.