Website privacy-safe analytics and legal footer links#2318
Merged
Conversation
Add Terms, Privacy, and Security links to the website footer and remove the experimental cookie consent popup to avoid cross-site consent drift with github.com. Gate Hydro analytics loading on browser privacy signals (Do Not Track and Global Privacy Control) so tracking-disabled users are respected without adding custom consent state. Update website security notes to match the current non-modal rendering flow. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0fdad70-4820-4c24-9e4a-35c82faf31ed
Contributor
There was a problem hiding this comment.
Pull request overview
Adds privacy-aware analytics loading, legal footer links, and documents website security hardening.
Changes:
- Respects DNT and GPC before loading Hydro analytics.
- Adds GitHub legal and security links.
- Introduces and documents CSP and referrer policies.
Show a summary per file
| File | Description |
|---|---|
website/src/components/Head.astro |
Adds privacy checks and security policies. |
website/src/components/Footer.astro |
Adds styled legal links. |
website/README.md |
Documents security controls and sanitization. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Medium
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Review details
Comments suppressed due to low confidence (1)
website/src/components/Footer.astro:44
- The PR description explicitly promises Terms, Privacy, and Security footer links, but this list ends after Privacy. Add the Security destination so the implemented footer matches the stated legal-link set.
<li>
<a href="https://docs.github.com/site-policy/privacy-policies/github-privacy-statement">
Privacy
</a>
</li>
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Medium
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Review details
Comments suppressed due to low confidence (1)
website/src/components/Footer.astro:44
- The PR description says the footer adds Terms, Privacy, and Security, but this legal list stops after Privacy. Add the promised Security link so the implementation matches the stated change.
<li>
<a href="https://docs.github.com/site-policy/privacy-policies/github-privacy-statement">
Privacy
</a>
</li>
- Files reviewed: 3/3 changed files
- Comments generated: 0 new
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The website needs standard GitHub legal links in the footer, and it should avoid loading analytics when users have browser-level tracking opt-out enabled.
What changed
Terms,Privacy, andSecuritylinks to the website footer.navigator.doNotTrack/window.doNotTrack/navigator.msDoNotTrack)navigator.globalPrivacyControl)website/README.mdsecurity notes so the sanitization note reflects current detail/file-browser rendering flow.Notes for reviewers
This is intentionally a lightweight privacy guardrail: analytics loading is skipped when browser signals indicate tracking should be disabled, without introducing a custom consent-management UX on this site.