Skip to content

Fix nested code fences in aws-well-architected-review issue template - #2449

Merged
aaronpowell merged 2 commits into
github:mainfrom
AClerbois:feature/fix-aws-well-architected-fences
Jul 28, 2026
Merged

Fix nested code fences in aws-well-architected-review issue template#2449
aaronpowell merged 2 commits into
github:mainfrom
AClerbois:feature/fix-aws-well-architected-fences

Conversation

@AClerbois

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description

Fixes a markdown fence-nesting bug in skills/aws-well-architected-review/SKILL.md.

The GitHub issue-body template (Step 6) was wrapped in a three-backtick ```markdown fence while itself containing three-backtick ```hcl and ```bash blocks. As a result, the HCL example's closing fence terminated the wrapper early, splitting the template, and the following fence started an unterminated block that swallowed the remaining workflow sections when rendered.

The fix wraps the whole template in a four-backtick fence so the nested three-backtick blocks render intact. Content is otherwise unchanged (2 lines modified).

The same issue was caught by Copilot review on the new Azure counterpart skill (#2448) and fixed there; this PR applies the identical fix to the original AWS skill.


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • New canvas extension.
  • Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
  • Other (please specify):

Additional Notes

npm run skill:validate passes; no changes to generated docs are needed (the skill's catalog entry is unchanged).


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

The issue-body template was wrapped in a three-backtick fence while
containing three-backtick HCL and Bash blocks, so the HCL example's
closing fence terminated the wrapper early and the following fence
swallowed the remaining workflow sections. Use a four-backtick wrapper
so the nested blocks render intact.
@AClerbois
AClerbois requested a review from aaronpowell as a code owner July 27, 2026 09:39
Copilot AI review requested due to automatic review settings July 27, 2026 09:39
@github-actions github-actions Bot added the skills PR touches skills label Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 1 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes nested Markdown rendering in the AWS Well-Architected review skill.

Changes:

  • Uses four-backtick outer fences so nested HCL and Bash blocks render correctly.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🔍 Vally Lint Results

✅ All checks passed

Scope Checked
Skills 1
Agents 0
Total 1
Severity Count
❌ Errors 0
⚠️ Warnings 0
ℹ️ Advisories 0

Summary

Level Finding
ℹ️ ✅ aws-well-architected-review (2/2 checks passed)
ℹ️ ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
ℹ️ ✓ spec-compliance: All spec checks passed.
ℹ️ ✓ [valid-refs] All file references across 1 skill(s) are valid.
ℹ️ ✓ valid-refs: All file references resolve to existing files within the skill directory.
ℹ️ 1 skill(s) linted, 1 passed
Full linter output
### Linting skills/aws-well-architected-review
✅ aws-well-architected-review (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.

1 skill(s) linted, 1 passed

Copilot AI review requested due to automatic review settings July 28, 2026 01:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@aaronpowell
aaronpowell merged commit b94ae92 into github:main Jul 28, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skills PR touches skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants