Inline test expectations: Rename tagIsOptional to tagIsIgnored#21786
Open
hvitved wants to merge 1 commit intogithub:mainfrom
Open
Inline test expectations: Rename tagIsOptional to tagIsIgnored#21786hvitved wants to merge 1 commit intogithub:mainfrom
tagIsOptional to tagIsIgnored#21786hvitved wants to merge 1 commit intogithub:mainfrom
Conversation
hvitved
force-pushed
the
inline-test-ignore-tags
branch
from
e58a8d8 to
80ccdcc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the inline expectations test framework to rename the tag hook from tagIsOptional to tagIsIgnored, aligning the API name with its intended semantics and reducing the chance of misuse in downstream tests.
Changes:
- Renamed the test hook from
tagIsOptionaltotagIsIgnoredand updated related documentation inInlineExpectationsTest.qll. - Removed the now-obsolete optional-expectation handling path and ensured ignored tags are filtered when parsing expectations.
- Updated the Rust type inference inline test to stop using the old
tagIsOptionalhook.
Show a summary per file
| File | Description |
|---|---|
| shared/util/codeql/util/test/InlineExpectationsTest.qll | Renames the tag hook to tagIsIgnored and updates the framework’s handling of ignored tags. |
| rust/ql/test/library-tests/type-inference/type-inference.ql | Removes usage of the old tagIsOptional hook in the Rust type inference inline expectations test. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Contributor
Author
Rerun has been triggered: 2 restarted 🚀 |
jketema
reviewed
May 4, 2026
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
Since you're also removing the only use of tagIsOptional, should be just remove it completely instead of renaming/fixing it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the tag to match the semantics and avoid confusion (such as me incorrectly using it in a Rust type inference test).