Update @github/copilot to 1.0.32-0#1103
Conversation
- Updated nodejs and test harness dependencies - Re-ran code generators - Formatted generated code
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Automated dependency bump of @github/copilot to 1.0.32-0 across the Node.js packages, followed by regenerating and formatting the SDK’s generated artifacts (TypeScript, Go, .NET, and Python codegen output adjustments).
Changes:
- Updated
@github/copilotto^1.0.32-0in Node.js and test harness package manifests/locks. - Updated code generation pipeline (Python post-processing) and regenerated SDK type outputs (TS/Go/.NET).
- Expanded generated RPC and event models (e.g., instructions sources RPC, additional session event fields).
Show a summary per file
| File | Description |
|---|---|
| test/harness/package.json | Bumps @github/copilot devDependency to ^1.0.32-0. |
| test/harness/package-lock.json | Locks updated @github/copilot + platform optional dependencies to 1.0.32-0. |
| nodejs/package.json | Bumps @github/copilot dependency to ^1.0.32-0. |
| nodejs/package-lock.json | Locks updated @github/copilot + platform optional dependencies to 1.0.32-0. |
| nodejs/samples/package-lock.json | Updates sample app lock to use @github/copilot ^1.0.32-0. |
| scripts/codegen/python.ts | Adds a Python post-processor to unwrap redundant lambda x: f(x) wrappers in generated code. |
| nodejs/test/python-codegen.test.ts | Updates/extends tests to assert redundant Python lambdas are collapsed. |
| nodejs/src/generated/session-events.ts | Regenerated session event types (adds agentId, factors out working directory context types). |
| nodejs/src/generated/rpc.ts | Regenerated RPC types + session RPC surface (adds instructions.getSources, refactors various schema-derived types). |
| go/rpc/generated_rpc.go | Regenerated Go RPC bindings (adds instructions API surface; updates/renames generated types). |
| go/generated_session_events.go | Regenerated Go session event models (context type reuse, new user message fields, deprecations). |
| dotnet/src/Generated/SessionEvents.cs | Regenerated .NET session event models (context type reuse, new user message fields, deprecations). |
| dotnet/src/Generated/Rpc.cs | Regenerated .NET RPC bindings (adds instructions API; refactors agent-related DTOs). |
Copilot's findings
Files not reviewed (3)
- nodejs/package-lock.json: Language not supported
- nodejs/samples/package-lock.json: Language not supported
- test/harness/package-lock.json: Language not supported
- Files reviewed: 6/15 changed files
- Comments generated: 3
| /// <summary>Currently selected custom agent, or null if using the default agent.</summary> | ||
| [JsonPropertyName("agent")] | ||
| public AgentGetCurrentResultAgent? Agent { get; set; } | ||
| public AgentInfo Agent { get => field ??= new(); set; } |
There was a problem hiding this comment.
AgentGetCurrentResult.Agent is documented as "...or null if using the default agent", but the property is non-nullable and the getter forces a non-null value by instantiating a new AgentInfo when the backing field is null. This will silently turn a JSON null into an empty object and prevents callers from distinguishing "no custom agent". Make this property nullable (AgentInfo?) and remove the field ??= new() behavior so JSON null is preserved.
| public AgentInfo Agent { get => field ??= new(); set; } | |
| public AgentInfo? Agent { get; set; } |
| type AgentGetCurrentResult struct { | ||
| // Currently selected custom agent, or null if using the default agent | ||
| Agent *AgentGetCurrentResultAgent `json:"agent"` | ||
| Agent AgentGetCurrentResultAgent `json:"agent"` |
There was a problem hiding this comment.
AgentGetCurrentResult.Agent is declared as a non-pointer struct, but the doc comment states it can be null when using the default agent. If the RPC response contains JSON null, encoding/json will fail to unmarshal into a struct. Consider making this field a pointer (e.g., *AgentGetCurrentResultAgent) so null is representable and aligns with the documented contract.
| Agent AgentGetCurrentResultAgent `json:"agent"` | |
| Agent *AgentGetCurrentResultAgent `json:"agent"` |
| // Working directory and git context at session start | ||
| type SessionContextChangedData struct { | ||
| // Current working directory path |
There was a problem hiding this comment.
The doc comment on SessionContextChangedData says "Working directory and git context at session start", but this type represents the payload for the session.context_changed event (i.e., the updated context after a change). The comment should be corrected to avoid misleading SDK consumers.
Automated update of
@github/copilotto version1.0.32-0.Changes
@github/copilotinnodejs/package.jsonandtest/harness/package.jsonscripts/codegen)Next steps
When ready, click Ready for review to trigger CI checks.