Skip to content

Clean up redundant Python codegen lambdas #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 1 commit into from
Apr 17, 2026
+489 −430
Merged

Clean up redundant Python codegen lambdas #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 48 additions & 1 deletion nodejs/test/python-codegen.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ describe("python session event codegen", () => {
'action = from_union([from_none, lambda x: parse_enum(SessionSyntheticDataAction, x)], obj.get("action", "store"))'
);
expect(code).toContain(
'summary = from_union([from_none, lambda x: from_str(x)], obj.get("summary", ""))'
'summary = from_union([from_none, from_str], obj.get("summary", ""))'
);
expect(code).toContain("uri: str");
expect(code).toContain("pattern: str");
Expand All @@ -83,6 +83,53 @@ describe("python session event codegen", () => {
expect(code).toContain("count: int");
});

it("collapses redundant callable wrapper lambdas", () => {
const schema: JSONSchema7 = {
definitions: {
SessionEvent: {
anyOf: [
{
type: "object",
required: ["type", "data"],
properties: {
type: { const: "session.synthetic" },
data: {
type: "object",
properties: {
summary: { type: "string" },
tags: {
type: "array",
items: { type: "string" },
},
context: {
type: "object",
properties: {
gitRoot: { type: "string" },
},
},
},
},
},
},
],
},
},
};

const code = generatePythonSessionEventsCode(schema);

expect(code).toContain('summary = from_union([from_none, from_str], obj.get("summary"))');
expect(code).toContain(
'tags = from_union([from_none, lambda x: from_list(from_str, x)], obj.get("tags"))'
);
expect(code).toContain(
'context = from_union([from_none, SessionSyntheticDataContext.from_dict], obj.get("context"))'
);
expect(code).not.toContain("lambda x: from_str(x)");
expect(code).not.toContain("lambda x: SessionSyntheticDataContext.from_dict(x)");
expect(code).not.toContain("from_list(lambda x: from_str(x), x)");
});

it("preserves key shortened nested type names", () => {
const schema: JSONSchema7 = {
definitions: {
Expand Down
Loading
Loading