Skip to content

Stop compiling Java in dependency update workflow#1594

Merged
stephentoub merged 1 commit into
mainfrom
stephentoub/fix-java-codegen-ci
Jun 7, 2026
Merged

Stop compiling Java in dependency update workflow#1594
stephentoub merged 1 commit into
mainfrom
stephentoub/fix-java-codegen-ci

Conversation

@stephentoub
Copy link
Copy Markdown
Collaborator

The dependency update workflow should only refresh dependencies and generated sources, then open the update PR. The removed Java compile validation step was causing update automation to fail on handwritten Java compilation errors that belong in normal Java CI or follow-up adaptation work.

This keeps Java codegen in place (mvn generate-sources -Pcodegen) but removes the subsequent mvn compile -Pskip-test-harness step, so the workflow no longer performs compilation for any language.

Generated by Copilot

The dependency update workflow should only refresh dependencies and generated sources. Remove the Java compile validation step so compilation failures are handled by normal CI instead of blocking update PR creation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@stephentoub stephentoub requested a review from a team as a code owner June 7, 2026 15:38
Copilot AI review requested due to automatic review settings June 7, 2026 15:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the update-copilot-dependency GitHub Actions workflow to focus strictly on dependency refresh + code generation, and to avoid failing the automated update workflow due to handwritten Java compilation issues that should be handled by normal Java CI (or follow-up adaptation work).

Changes:

  • Removed the Java compilation validation step (mvn compile -Pskip-test-harness) from the dependency update workflow.
  • Kept Java code generation (mvn generate-sources -Pcodegen) as part of the automated update process.
Show a summary per file
File Description
.github/workflows/update-copilot-dependency.yml Removes Java compile validation so dependency update PR automation doesn’t fail on handwritten Java compilation errors.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@stephentoub stephentoub enabled auto-merge June 7, 2026 15:39
@stephentoub stephentoub disabled auto-merge June 7, 2026 15:39
@stephentoub stephentoub merged commit 9c4d637 into main Jun 7, 2026
11 checks passed
@stephentoub stephentoub deleted the stephentoub/fix-java-codegen-ci branch June 7, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants