Skip to content

Patch 2#45206

Closed
teesaelee1998-ux wants to merge 2 commits into
github:mainfrom
teesaelee1998-ux:patch-2
Closed

Patch 2#45206
teesaelee1998-ux wants to merge 2 commits into
github:mainfrom
teesaelee1998-ux:patch-2

Conversation

@teesaelee1998-ux

@teesaelee1998-ux teesaelee1998-ux commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
apps/creating-github-apps/authenticating-with-a-github-app/authenticating-as-a-github-app-installation.md

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • Dockerfile
  • Dockerfile.openapi_decorator

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/how-tos/security-for-github-actions/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter contentType: rai.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jul 18, 2026
jedijashwa added a commit to jedijashwa/pullmark that referenced this pull request Jul 19, 2026
@jedijashwa @claude
Render YAML front matter as metadata instead of prose (#6)
dfdc01d 
A leading --- fence now renders as a quiet key/value table everywhere:
documents and Quick Look show a collapsed "Front matter" details block;
rendered diffs show compact metadata tables inside the usual red/green
wrappers instead of walls of bold prose.

- MarkdownBlocks.split keeps a leading front matter fence as one block
  (even across blank lines) so diffs treat the metadata atomically, with
  CRLF-safe fence matching; mid-document --- rules and setext headings
  never match.
- DiffSegmentPayload carries per-side fmText/fmOldText flags computed in
  Swift (only Swift knows both sides' true line numbers — the pairing in
  github/docs#45206 gives the segment the new side's line numbers while
  only the old side is front matter). Word-level diff marks are skipped
  for front-matter segments.
- app.js renders the table line-based and safe (textContent, no YAML
  parser): simple `key: value` lines split on the first colon, nested or
  complex lines stay preformatted. Blame still annotates the fence's file
  lines on the details element.
- Quick Look's StaticRenderer emits the same details/table markup from
  its JSC pipeline, with matching styles.
- Styling on primer variables so all reading themes and both appearances
  adapt.
- Tests: front-matter block splitting incl. line numbers, hr/setext
  false-positive guards, CRLF, per-side flags, wordDiff skipping; kitchen
  sink gains a front matter header with render-check assertions.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jedijashwa added a commit to jedijashwa/pullmark that referenced this pull request Jul 19, 2026
@jedijashwa @claude
Site: fresh screenshots and current feature story
c82e989 
New real window captures (retina, light): the hero is now the README
with the blame gutter on — history in the margin — the reviewing
section shows the github/docs#45206 front-matter diff (old front
matter as a metadata table, and the patch's breakage plainly visible),
and the reading section gains the Settings → Themes window with its
three live preview cards. Feature list updated for blame/line history,
front matter, and Update Now / What's New; honest alt text and
captions throughout. Verified in headless Chrome, light + dark +
390px.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jedijashwa added a commit to jedijashwa/pullmark that referenced this pull request Jul 19, 2026
@jedijashwa @claude
Render YAML front matter as metadata instead of prose (#6)
ec2d4f7 
A leading --- fence now renders as a quiet key/value table everywhere:
documents and Quick Look show a collapsed "Front matter" details block;
rendered diffs show compact metadata tables inside the usual red/green
wrappers instead of walls of bold prose.

- MarkdownBlocks.split keeps a leading front matter fence as one block
  (even across blank lines) so diffs treat the metadata atomically, with
  CRLF-safe fence matching; mid-document --- rules and setext headings
  never match.
- DiffSegmentPayload carries per-side fmText/fmOldText flags computed in
  Swift (only Swift knows both sides' true line numbers — the pairing in
  github/docs#45206 gives the segment the new side's line numbers while
  only the old side is front matter). Word-level diff marks are skipped
  for front-matter segments.
- app.js renders the table line-based and safe (textContent, no YAML
  parser): simple `key: value` lines split on the first colon, nested or
  complex lines stay preformatted. Blame still annotates the fence's file
  lines on the details element.
- Quick Look's StaticRenderer emits the same details/table markup from
  its JSC pipeline, with matching styles.
- Styling on primer variables so all reading themes and both appearances
  adapt.
- Tests: front-matter block splitting incl. line numbers, hr/setext
  false-positive guards, CRLF, per-side flags, wordDiff skipping; kitchen
  sink gains a front matter header with render-check assertions.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jedijashwa added a commit to jedijashwa/pullmark that referenced this pull request Jul 19, 2026
@jedijashwa @claude
Site: fresh screenshots and current feature story
955dd1b 
New real window captures (retina, light): the hero is now the README
with the blame gutter on — history in the margin — the reviewing
section shows the github/docs#45206 front-matter diff (old front
matter as a metadata table, and the patch's breakage plainly visible),
and the reading section gains the Settings → Themes window with its
three live preview cards. Feature list updated for blame/line history,
front matter, and Update Now / What's New; honest alt text and
captions throughout. Verified in headless Chrome, light + dark +
390px.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@teesaelee1998-ux