fix: accept empty/missing arguments for zero-param tools (get_me)#2607
Open
advancedresearcharray wants to merge 2 commits into
Open
fix: accept empty/missing arguments for zero-param tools (get_me)#2607advancedresearcharray wants to merge 2 commits into
advancedresearcharray wants to merge 2 commits into
Conversation
advancedresearcharray
force-pushed
the
fix/get-me-empty-arguments-2587
branch
from
fa5f70b to
5f73549
Compare
advancedresearcharray
force-pushed
the
fix/get-me-empty-arguments-2587
branch
from
5f73549 to
1af8d2b
Compare
Treat nil or empty Arguments JSON as {} before unmarshaling so clients
that omit arguments work with tools that have empty input schemas.
Add table-driven tests covering nil, empty byte slice, and explicit {}.
Fixes github#2587
advancedresearcharray
force-pushed
the
fix/get-me-empty-arguments-2587
branch
3 times, most recently
from
31ff4c5 to
8178649
Compare
Add an integration test that exercises the full get_me handler path when clients omit the arguments field, matching the failure mode in github#2587.
advancedresearcharray
force-pushed
the
fix/get-me-empty-arguments-2587
branch
from
8178649 to
d163e4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
argumentsontools/callas{}before JSON unmarshalingget_meand other zero-parameter tools when clients omitargumentsentirelyFixes #2587
Test plan
go test ./pkg/inventory/...TestNewServerToolWithContextHandler_EmptyArguments_TreatedAsEmptyObject(nil, empty byte slice, explicit{})