fix: correct online state on startup instead of waiting for a network event - #3147
Open
setchy wants to merge 1 commit into
Open
fix: correct online state on startup instead of waiting for a network event#3147setchy wants to merge 1 commit into
setchy wants to merge 1 commit into
Conversation
Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TanStack Query's onlineManager initializes to online: true regardless of the device's actual network state, and only self-corrects when the browser fires a native online/offline event. Since browsers only emit events on transitions, a device that's already offline when Gitify launches (airplane mode, VPN down, etc.) never gets one — so the app incorrectly believes it's online from the first render, fires the notifications query, and only discovers it's offline after that query fails and retries.
Fix
Added a single onlineManager.setOnline(navigator.onLine) call at the start of useOnlineStatus's mount effect, before the existing subscription logic. This actively force-corrects onlineManager's state to match reality on startup, instead of passively waiting for a future browser event that may never come.