chore(Authorization)!: Updates Token Storage Structure #400
Draft
jbottigliero wants to merge 3 commits intomainfrom
Draft
chore(Authorization)!: Updates Token Storage Structure #400jbottigliero wants to merge 3 commits intomainfrom
jbottigliero wants to merge 3 commits intomainfrom
Conversation
9a26015 to
d9e00ba
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
==========================================
- Coverage 98.82% 96.79% -2.04%
==========================================
Files 70 70
Lines 1191 1247 +56
Branches 194 208 +14
==========================================
+ Hits 1177 1207 +30
- Misses 14 39 +25
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
- Updates the structure of how tokens are stored on the configured storage system to allow retrieval by scope when necessary. - **Allows for multiple tokens, for the same resource server, with different scopes to be stored.**
073bab0 to
8dea668
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
==========================================
- Coverage 94.89% 94.60% -0.29%
==========================================
Files 75 75
Lines 1411 1465 +54
Branches 227 241 +14
==========================================
+ Hits 1339 1386 +47
- Misses 71 78 +7
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8dea668 to
b6a49b2
Compare
b6a49b2 to
0968682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{CLIENT_ID}:{RESOURCE_SERVER}.AuthorizationManager.getGlobusAuthToken()andAuthorizationManager.hasGlobusAuthToken()have been deprecated; UseAuthorizationManager.tokens.authinstead.authenticatedevent no longer provides atokenas part of the event payload. Originally, this would only provide the Globus Auth token, but your application might never require a Globus Auth token (and only tokens from a specific service).This has been marked as a breaking change based on the structure change to how tokens are stored; This would only be a breaking change if you are accessing stored tokens in
localStorageorsessionStoragedirectly, which is not advised (use theTokenManagerinstance instead).