fix(Search, Typescript): Allow creating GSearchRequest without 'q' (but requiring 'filters')#777
Open
jbottigliero wants to merge 1 commit intomainfrom
Open
fix(Search, Typescript): Allow creating GSearchRequest without 'q' (but requiring 'filters')#777jbottigliero wants to merge 1 commit intomainfrom
jbottigliero wants to merge 1 commit intomainfrom
Conversation
…ut requiring 'filters')
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 86 86
Lines 1759 1759
Branches 294 294
=======================================
Hits 1685 1685
Misses 73 73
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jakeglobus
reviewed
Mar 2, 2026
Comment on lines
+149
to
+153
| // @ts-expect-error `filters` should require at least one element | ||
| const requireOneFilter: query.GSearchRequest = { | ||
| filters: [], | ||
| }; | ||
| expect(requireOneFilter).toBeDefined(); |
Contributor
There was a problem hiding this comment.
I don't understand what this is supposed to be testing. When is requireOneFilter expected to be undefined? Is this to produce a typescript error if GSearchRequest is changed in a way that's incompatible with having an empty filters array?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.globus.org/api/search/reference/post_query/#gsearchrequest