-
Notifications
You must be signed in to change notification settings - Fork 441
fix: In getLedgerDevice() error, mention CGO_ENABLED=1 #4952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 Pending initial approval by a review team member, or review from tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
88fab13 to
531d737
Compare
Signed-off-by: Jeff Thompson <[email protected]>
531d737 to
457d8c9
Compare
Resolves #2737
As required by the HID library, the executable must be built with
CGO_ENABLED=1in order to find the Ledger. We want to keep building without this flag by default so that the binary is deterministic. So we just inform the user.getLedgerDeviceerror wrapped message, add "Try building with CGO_ENABLED=1"The error message looks like:
This PR is a minimal solution as an alternative to putting
CGO_ENABLED=1in the gnokey Makefile.