Update data structure and logic to handle both Swagger 2 and OpenAPI 3#234
Update data structure and logic to handle both Swagger 2 and OpenAPI 3#234ndeloof wants to merge 5 commits intogo-openapi:masterfrom
Conversation
|
Thank you. I’ll take a thorough look at it and at your fork as well. We might have a to discuss a few things. I’ll let you know shortly |
…3 documents Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
updated: added a 2nd commit to run spec_test with swagger and openapi files, to confirm both are well supported |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 67.51% 63.69% -3.82%
==========================================
Files 30 34 +4
Lines 2395 2749 +354
==========================================
+ Hits 1617 1751 +134
- Misses 615 791 +176
- Partials 163 207 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
@ndeloof Nicolas perhaps we should have a separate conversation about this piece of work. Since we are on the same timezone I suggest we convene at some point this week. I see you're pushing a lot of stuff in different repos and I don't quite get your approach yet. |
|
Can be discussed on Discord: https://discord.gg/DrafRmZx I you prefer Slack (open til March 31st): https://goswagger.slack.com/archives/C04R30YMU |
|
@ndeloof so TL;DR keep that one on your fork. I can't be merged here. Closing. |
Change type
🆕 Add support for Open API 3.x
Short description
This PR introduce support for Open API 3.x document
Fixes
fixes #21
Full description
Add required attributes so the same codebase can be used to parse swagger 2.x and openapi 3.x documents.
This is used in https://github.com/allons-y/openapi (go-swagger fork) as a proof of concept
Let me know if this makes sense, then I'll adapt tests so they are executed and adapted for both file formats
Checklist