fix: prevent emoji picker from closing when clicking search input #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The emoji picker (vuemoji-picker) uses emoji-picker-element which renders its internal elements inside Shadow DOM. The closeWhenClickedOutside helper was using parentElement traversal which doesn't work across shadow boundaries, causing clicks on the search input to incorrectly trigger the close callback. This fix: - Uses event.composedPath() instead of parentElement traversal, which properly includes elements inside Shadow DOM - Updates Reactions.vue to pass the actual DOM element ($el) instead of the Vue component instance 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://community.vikunja.io/t/cannot-search-for-reaction-emoji/4207/1
Summary
vuemoji-pickerwrapsemoji-picker-elementwhich uses Shadow DOMcloseWhenClickedOutsidehelper was usingparentElementtraversal which doesn't cross shadow boundariesChanges
closeWhenClickedOutsideto useevent.composedPath()which properly includes elements inside Shadow DOMReactions.vueto pass the actual DOM element ($el) instead of the Vue component instanceTest plan
🤖 Generated with Claude Code