Harden rmap ordering and retry ticker advances#69
Merged
Conversation
Track replicated-map writes by committed revision so destroy/reconnect recovery and SetAndWait acknowledgements stay ordered under concurrent updates. Align stream sink cleanup with the same destroy protocol and treat destroy tombstones as intentional protocol state in tests.
Rearm the local timer after transient map write failures so distributed tickers recover without waiting for unrelated map traffic. Add regression coverage for the failed advance path.
Record the repository-specific architecture and coding rules in-tree so future changes follow Pulse's contracts and review expectations consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetAndWaitacknowledgements stay consistent under concurrent updatesAGENTS.mdguidance in-treeTest plan
go test ./rmap ./streaming ./poolin a Redis-backed environmentrmap.Destroy()and reconnect keep revision ordering intact across replica resyncNotes
3a2cc7fbefore opening this PR and did not find a blocker that required changes before shipping.go test ./poolcurrently fails during Redis test setup withEOF, so I did not claim a clean package test run in this environment.