fix(block-migrate): remove unnecessary pass-by-reference on WP_Post - #2666
Open
faisalahammad wants to merge 1 commit into
Open
fix(block-migrate): remove unnecessary pass-by-reference on WP_Post#2666faisalahammad wants to merge 1 commit into
faisalahammad wants to merge 1 commit into
Conversation
WP_Post is an object, already passed by handle to closures. The & on the the_post callback parameter was redundant and triggers a PHP 8.x warning because WP_Hook::apply_filters() passes arguments by value. Fixes godaddy-wordpress#2662
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2662
The
the_postcallback inincludes/block-migrate/loader.phpdeclaredWP_Post &$postas pass-by-reference. SinceWP_Postis an object in PHP, it is already passed by handle to closures - the&is unnecessary and generates a PHP 8.x warning becauseWP_Hook::apply_filters()passes arguments by value.Screenshots
Not applicable.
Types of changes
Bug fix (non-breaking change which fixes an issue)
How has this been tested?
Confirmed the warning no longer appears in PHP 8.3 error logs.
WP_Postis an object, so removing the reference does not affect the closure's ability to mutate$post->post_content(line 60).Acceptance criteria
PHP 8.x warning on every page load is removed.
Checklist: