Skip to content

Conversation

@asaarnak
Copy link
Contributor

No description provided.

@asaarnak
Copy link
Contributor Author

Hei! @JlUgia
Could you review this PR?
This is the last dependency for us to support jvmTarget 11.

@asaarnak
Copy link
Contributor Author

@JlUgia
I have updated the changelog and version in PR.
Could you review this?

@JlUgia
Copy link
Member

JlUgia commented Nov 18, 2025

Good day @asaarnak, thank you for your contribution.
There's no need to include release info (version and changelog) since the release lifecyle is not intimately bound to PRs.
Also, let's use the latest syntax grouping for kotlinOptions (see docs).

@asaarnak
Copy link
Contributor Author

@JlUgia
I have used flutter packages repo as a reference for tested versions and updated the build.gradle file with kotlin and jvm versions.
Also removed the deprecated kotlinOptions like you requested.
Compared against this:
https://github.com/flutter/packages/blob/main/packages/video_player/video_player_android/android/build.gradle

@JlUgia
Copy link
Member

JlUgia commented Nov 21, 2025

Good day @asaarnak this code doesn't build to me. Does it to you?
Please take a look and update to a config that builds successfully.

@asaarnak
Copy link
Contributor Author

@JlUgia What errors did you get? For us this works as a git dependency.

@asaarnak
Copy link
Contributor Author

@JlUgia
Bumped the gradle plugin like it was done here: flutter/packages@061eedc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants