Add Kotlin tabs to the Skills page - #2156
Open
happyhuman wants to merge 3 commits into
Open
Conversation
The Skills page documented Python, TypeScript and Go but not Kotlin, even though SkillToolset has existed since adk-kotlin v0.1.0. This was missed because every earlier coverage audit diffed one release tag against the next, so symbols that already existed at v0.1.0 were never checked. Kotlin's shape differs from Python's in two ways the tabs need to show. SkillToolset takes a single SkillSource rather than a list of loaded skills, so NewFileSystemSource discovers every skill under a base directory instead of loading them one by one. And like ADK Go, Kotlin ships no built-in source for skills defined in code, so the inline-skills tab implements SkillSource directly rather than pretending a Python-style model class exists.
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The badge said Kotlin v0.8.0, which is the version adk-docs compiles against, not the version the feature landed in. Every other badge on the page and across the site names the introducing release - SkillToolset has been present since v0.1.0.
The Experimental callout invites feedback per SDK but listed only Python, TypeScript and Go, which is now inconsistent with the Kotlin badge this branch adds. The link has no template parameter, unlike its three siblings, because adk-kotlin has no issue templates - its .github directory holds only workflows, so ?template=feature_request.md would silently fall back to a blank issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds Kotlin to all three tab groups on
docs/skills/index.md(get started, skills defined in code, skills read from the filesystem), plus theKotlin v0.1.0language badge and a Kotlin entry under Next steps.New snippet file:
examples/kotlin/snippets/skills/SkillsExample.kt, registered infiles_to_test.txt.Why
SkillToolsethas existed since adk-kotlin v0.1.0, but the page has never shown Kotlin. Earlier coverage audits diffed one release tag against the next, so anything that already existed at v0.1.0 was invisible to them.Kotlin differs from the sibling tabs in two ways
Both are deliberate, not translation shortcuts:
SkillToolsettakes a singleSkillSource, not a list of pre-loaded skills plusadditional_tools.NewFileSystemSourcediscovers every skill directory under a base directory, so there is no per-skill load call. Extra tools go on the agent'stools, not on the toolset.NewFileSystemSource(JVM/Android) andAssetSkillSource(Android-only) implementSkillSourceat v0.8.0. The inline-skills tab therefore implementsSkillSourcedirectly, mirroring how the ADK Go tab handles the same gap, rather than inventing a Python-style model class.AssetSkillSourceisandroidMainand is intentionally left out of scope.Verification
Grounded against the
v0.8.0git tag (not the adk-kotlin working tree). Full ladder green:gradlew build(JDK 17, KSP)files_to_test.txtregistrationL4 (
runSnippets) reports SKIP — no such Gradle task exists in this repo, so it is skipped for every snippet, not just these.The page is badged Experimental for the other languages; I checked and
SkillToolsetcarries no opt-in annotation at v0.8.0, so the Kotlin badge is added plainly.Tracked as KT-23.
Update: the badge originally read
Kotlin v0.8.0, which is the version adk-docs compiles against, not the release the feature shipped in. Corrected to the introducing version, matching the sibling badges and the rest of the site.