Show maxLlmCalls in the RunConfig Kotlin tabs - #2163
Open
happyhuman wants to merge 1 commit into
Open
Conversation
Two groups on the RunConfig page had a Kotlin tab that set only streamingMode while the Python, TypeScript and Java siblings also set max_llm_calls. The tab existed and every symbol in it was valid, so neither a symbol diff nor a missing-tab scan could see the gap - only comparing a tab's contents against its siblings. Also corrects the runtime-limits prose, which described the overflow error purely in Python terms. Kotlin rejects Int.MAX_VALUE the same way. The audio and speech group is deliberately left without a Kotlin tab: Kotlin's RunConfig carries only streamingMode, maxLlmCalls and customMetadata, so there is no speechConfig or responseModalities to show.
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
maxLlmCallsto the two Kotlin regions ondocs/runtime/runconfig.md(basic_usage→ 200,streaming_config→ 150), matching the values their siblings already use.Why this was invisible
This is a parity gap, not a missing tab. Both Kotlin tabs exist, and every symbol in them is valid at v0.8.0 — so a symbol diff sees nothing and a "missing Kotlin tab" scan sees nothing. Only comparing a tab's contents against its siblings surfaces it.
RunConfig.maxLlmCallshas been there since v0.1.0.Notes
streaming_configregion gets a comment. Its siblings setsupportCfcalongsidemaxLlmCalls; Kotlin'sRunConfighas no equivalent, so the comment says so rather than leaving the reader to wonder what was dropped.RunConfigcarries onlystreamingMode,maxLlmCallsandcustomMetadata— there is nospeechConfigorresponseModalitiesto show, so a tab there would have to invent API.initblock "rejectsInt.MAX_VALUEand any value <= 0". At v0.8.0 onlyInt.MAX_VALUEthrows; a value <= 0 logs a warning and disables the limit. The existing page prose ("Set to 0 or negative for unlimited calls") is therefore correct for Kotlin as written, and I left it alone.LlmCallsLimitExceededExceptionis not documented here, because the page does not describe what happens on limit exhaustion in any language. That is a docs-wide gap rather than a Kotlin one; adding a Kotlin-only mention would create a new asymmetry.Verification
Grounded against the
v0.8.0git tag. Full ladder green (L0, L1 compile with KSP, L2 ktlint, L3, L5, L6). L4runSnippetsSKIP — no such Gradle task in this repo.Tracked as KT-31.