Add switches to the host init script to toggle legacy behaviour - #3139
Open
dxapd wants to merge 1 commit into
Open
Add switches to the host init script to toggle legacy behaviour#3139dxapd wants to merge 1 commit into
dxapd wants to merge 1 commit into
Conversation
dxapd
marked this pull request as ready for review
September 3, 2026 23:56
Collaborator
Can we do this without having to do this at init? Can we interrogate nftables and see if our tables and chains exist, and if not, install them then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add two new flags for toggling static resource initialization as well as running cvdalloc's init (which is to be implemented in the final PR in this series).
due to the way nftables works, cvdalloc also needs to do a small amount of install-time init (namely, creating its tables and chains). that code is better off living inside the cvdalloc binary, so we have the init script, which is our one hook point into install and uninstall, invoke it at exactly those times.
this change, as is, should be a no-op. the code enclosed within the
if [ "${allocate_static_resources}" = "1" ]; thenbranches is the code we hope to delete one day, but until that day it will remain.