Open
Conversation
added 2 commits
May 10, 2017 04:39
This keeps breaking autofdo. perf 4.7 always generates a TIME_CONV event which causes create_gcov to fail. This patch makes the perf parser ignore all the perf record generated events. To avoid this problem in the future I predicted the range beyond the current records.
Older Atom CPUs don't have predicted/mispredicted bits in the LBR, so set neither predicted nor mispredicted. The perf reader has a sanity check that either of these bits have to be set. Just remove the check.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
|
Andi, Thanks for the commit! Please sign the CLA and then I'll merge this pull request. Thanks, |
|
I just tested this branch on the latest Linux & perf (both compiled from 4.13) and after applying the patch autofdo could successfully read my Thanks for the patch @andikleen ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are two patches fixing autofdo for newer perf versions and for Atom CPUs.