Skip to content

Conversation

@thaJeztah
Copy link
Contributor

Notable changes:

  • nat: assorted optimisations and test-improvements
  • nat: assorted test cleanups and improvements
  • nat: introduce String method on PortMapping
  • nat: ParsePortSpecs: reduce allocations and improve performance
  • nat: ParsePortSpecs: simplify
  • sockets: deprecate DialerFromEnvironment, GetProxyEnv
  • sockets: deprecate DialPipe
  • sockets: implement AF_UNIX sockets on Windows
  • sockets: make NewUnixSocket, WithChown, WithChmod unix-only
  • tlsconfig: align client and server defaults, remove weak CBC ciphers
  • tlsconfig: Remove support for encrypted TLS private keys
  • tlsconfig: remove uses of PreferServerCipherSuites

full diff: docker/go-connections@v0.5.0...v0.6.0

@thaJeztah thaJeztah force-pushed the bump_go_connections branch from d2c3d34 to 0c3833f Compare December 5, 2025 20:24
@dims
Copy link
Collaborator

dims commented Dec 8, 2025

ci job failures, please look:

Run source build/config/plain.sh
>> upgrading golangci-lint from  to 2.6.2
golangci/golangci-lint info checking GitHub for tag 'v2.6.2'
golangci/golangci-lint info found version: 2.6.2 for v2.6.2/linux/amd64
golangci/golangci-lint info installed /home/runner/go/bin/golangci-lint
>> running golangci-lint using configuration at .golangci.yml
0 issues.
Error: cmd/internal/pages/docker.go:26:13: could not import github.com/google/cadvisor/container/docker/utils (/home/runner/work/cadvisor/cadvisor/container/docker/utils/docker.go:24:14: could not import github.com/docker/docker/api/types/image (/home/runner/go/pkg/mod/github.com/docker/[email protected]+incompatible/api/types/image/image_inspect.go:4:2: could not import github.com/docker/docker/api/types/container (/home/runner/go/pkg/mod/github.com/docker/[email protected]+incompatible/api/types/container/config.go:7:2: could not import github.com/docker/go-connections/nat (../../../../go/pkg/mod/github.com/docker/[email protected]+incompatible/api/types/container/config.go:7:2: missing go.sum entry for module providing package github.com/docker/go-connections/nat (imported by github.com/docker/docker/api/types/container); to add:
	go get github.com/docker/docker/api/types/[email protected]+incompatible)))) (typecheck)
	dockerutil "github.com/google/cadvisor/container/docker/utils"
	           ^
1 issues:
* typecheck: 1
make: *** [Makefile:90: lint] Error 1
Error: Process completed with exit code 2.

@thaJeztah thaJeztah force-pushed the bump_go_connections branch from 0c3833f to 4478b35 Compare December 9, 2025 08:28
@thaJeztah
Copy link
Contributor Author

Weird; had that one on another PR as well, and that one was some flaky; I rebased and pushed to see if it resolved itself

Notable changes:

- nat: assorted optimisations and test-improvements
- nat: assorted test cleanups and improvements
- nat: introduce String method on PortMapping
- nat: ParsePortSpecs: reduce allocations and improve performance
- nat: ParsePortSpecs: simplify
- sockets: deprecate DialerFromEnvironment, GetProxyEnv
- sockets: deprecate DialPipe
- sockets: implement AF_UNIX sockets on Windows
- sockets: make NewUnixSocket, WithChown, WithChmod unix-only
- tlsconfig: align client and server defaults, remove weak CBC ciphers
- tlsconfig: Remove support for encrypted TLS private keys
- tlsconfig: remove uses of PreferServerCipherSuites

full diff: docker/go-connections@v0.5.0...v0.6.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Contributor Author

Rebased this one to get a fresh run of CI (if you can give it another kick)

@dims dims added this pull request to the merge queue Dec 16, 2025
Merged via the queue into google:master with commit 19a4038 Dec 16, 2025
8 checks passed
@thaJeztah thaJeztah deleted the bump_go_connections branch December 16, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants