Fix Dagger validation to correctly identify and reject private Kotlin classes and members. - #5237
Merged
Merged
Conversation
… classes and members. This change updates XElements.isPrivate to check both isPrivate() and isKtPrivate(). This ensures that Kotlin-specific private modifiers are properly recognized during Dagger's validation, preventing injection into private Kotlin classes, constructors, fields, and methods. RELNOTES=Fix Dagger validation to correctly identify and reject private Kotlin classes and members. PiperOrigin-RevId: 957173860
copybara-service
Bot
force-pushed
the
test_954879522
branch
from
July 31, 2026 16:06
21b2d81 to
b302547
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Dagger validation to correctly identify and reject private Kotlin classes and members.
This change updates XElements.isPrivate to check both isPrivate() and isKtPrivate(). This ensures that Kotlin-specific private modifiers are properly recognized during Dagger's validation, preventing injection into private Kotlin classes, constructors, fields, and methods.
RELNOTES=Fix Dagger validation to correctly identify and reject private Kotlin classes and members.