Skip to content

Add unit test for parameterized @AssistedFactory with inaccessible type arguments. #5240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 31, 2026
Merged

Add unit test for parameterized @AssistedFactory with inaccessible type arguments. #5240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions javatests/dagger/internal/codegen/AssistedFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,4 +543,67 @@ public void testAssistedFactoryFromLibraryWithoutProcessor() {
});
}
}

@Test
public void testPublicGenericAssistedFactoryWithPackagePrivateTypeArguments() {
Source foo =
CompilerTests.javaSource(
"pkg.a.Foo",
"package pkg.a;",
"",
"import dagger.assisted.Assisted;",
"import dagger.assisted.AssistedFactory;",
"import dagger.assisted.AssistedInject;",
"",
"public class Foo<T> {",
" @AssistedInject",
" Foo(@Assisted T arg) {}",
"",
" @AssistedFactory",
" public interface Factory<T> {",
" Foo<T> create(T arg);",
" }",
"}");

Source bar =
CompilerTests.javaSource(
"pkg.b.PackagePrivateBar", "package pkg.b;", "", "class PackagePrivateBar {}");

Source client =
CompilerTests.javaSource(
"pkg.b.Client",
"package pkg.b;",
"",
"import javax.inject.Inject;",
"import pkg.a.Foo;",
"",
"public class Client {",
" @Inject",
" Client(Foo.Factory<PackagePrivateBar> factory) {}",
"}");

Source component =
CompilerTests.javaSource(
"test.TestComponent",
"package test;",
"",
"import dagger.Component;",
"import pkg.b.Client;",
"",
"@Component",
"interface TestComponent {",
" Client getClient();",
"}");

CompilerTests.DaggerCompiler daggerCompiler =
CompilerTests.daggerCompiler(foo, bar, client, component)
.withProcessingOptions(compilerMode.processorOptions());

// TODO(b/532992111): Fix javac visibility errors when using generic @AssistedFactory interfaces
// across packages with package-private type arguments.
daggerCompiler.compile(
subject -> {
subject.hasErrorContaining("PackagePrivateBar");
});
}
}
Loading