Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hello @dbaileychess, I signed the cla (the check is passing now). Tell me if something is missing thanks! |
|
@fliiiix -- do you know if there's any history or lore as to why reflection isn't packaged with the flatbuffers package? |
|
@inimaz are all the updates in the reflection folder a result of new code gen? |
No unfortunately not and I don't use reflection myself |
Solves #8608.
Setup.py was not taking into consideration the
flatbuffers.reflectionpackage.Adding it via
find_packages().