Fix heap buffer overflow in StructDef Deserialize#8954
Open
ShangzhiXu wants to merge 1 commit intogoogle:masterfrom
Open
Fix heap buffer overflow in StructDef Deserialize#8954ShangzhiXu wants to merge 1 commit intogoogle:masterfrom
ShangzhiXu wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jtdavis777
reviewed
Mar 6, 2026
| const auto& of = *(object->fields()); | ||
| auto indexes = std::vector<uoffset_t>(of.size()); | ||
| for (uoffset_t i = 0; i < of.size(); i++) indexes[of.Get(i)->id()] = i; | ||
| for (uoffset_t i = 0; i < of.size(); i++) |
Collaborator
There was a problem hiding this comment.
a small optimization I would suggest -- we should read of.size() only once (before the previous line) and use the cached value.
Collaborator
There was a problem hiding this comment.
same thing for of.Get(i)->id() -- we should call this only once per loop instead of twice.
jtdavis777
added
the
waiting-for-update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8932
#8932
This PR adds a bounds check in StructDef::Deserialize to prevent a heap buffer overflow when reading malformed bfbs files. If the field ID exceeds the size of the vector, it safely returns false.
Works on my machine to fix the bug