fix: add depth limit to prevent parser crash#871
Open
JohannesLks wants to merge 1 commit intogoogle:masterfrom
Open
fix: add depth limit to prevent parser crash#871JohannesLks wants to merge 1 commit intogoogle:masterfrom
JohannesLks wants to merge 1 commit intogoogle:masterfrom
Conversation
Deeply nested input exhausts the goroutine stack, causing an unrecoverable fatal error that bypasses recover(). Add a depth counter to parse() with a limit of 500 (matching MaxStack). Signed-off-by: Lukas Johannes Moller <research@johannes-moeller.dev>
JohannesLks
force-pushed
the
fix/parser-depth-limit
branch
from
6b418c5 to
43a0d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #870
Deeply nested input exhausts the goroutine stack, causing an unrecoverable fatal error that bypasses recover(). Add a depth counter to parse() with a limit of 500 (matching MaxStack).