reskin flip camera button - #544
Open
Kimblebee wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the FlipCameraButton to use FilledIconButton with custom styling and adds a Compose preview for it. Feedback on these changes includes reverting an unrelated bump of minSdk in libs.versions.toml, removing an unused IconButton import, and improving the button's visibility on bright viewfinders by using a semi-transparent dark container color instead of a white one.
Kimblebee
force-pushed
the
kim/reskin/flip_camera_button
branch
from
July 30, 2026 20:24
f4b246c to
04fa0bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the flip camera button to match design specs.
note that in 9:16 aspect ratio, the viefinder will overlap with this button. Problem here is that should the viewfinder appear white, this button will appear near-invisible. Looking to fix it!
