fix: align SOAR setup entrypoint#261
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
Author
|
This is ready for review. The SOAR setup entrypoint is aligned, and the visible checks are green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy
server/secops-soar/setup.pyconsole script points at the asyncmaincoroutine. That can create an entrypoint which returns a coroutine instead of running the server.This aligns the setup.py entrypoint with pyproject.toml by using
run_main, and also updates the setup.py version to match the package version in pyproject.toml.Tests:
python3 -m py_compile server/secops-soar/setup.pypython3 setup.py --name --versionfromserver/secops-soargit diff --check