parallelization changes

[pkaushik-pythian]

Created the script in 3 phases introduced in install-oracle.sh:

Phase 1: Software install and host prepare runs both on Primary and standby nodes

Phase 2: Primary database is created

Phase 3: Database is copied to standbys

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pkaushik-pythian
Once this PR has been reviewed and has the lgtm label, please assign mfielding for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-prow]

Hi @pkaushik-pythian. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mfielding]

/ok-to-test

[pkaushik-pythian]

Attaching gist below:
https://gist.github.com/gmarcospythian/aab02e4bf2e51a2ca12b14cffa3b461a

[mfielding]

The non-Terraform tests seem to be failing because on parse errors of the generated inventory:

https://oss.gprow.dev/view/gs/gcp-oracle-prow-bucket/pr-logs/pull/google_oracle-toolkit/369/oracle-toolkit-install-single-instance-on-bms/1975649660341063680 says

./install-oracle.sh --ora-swlib-bucket gs://bmaas-testing-oracle-software --instance-ssh-user ansible --instance-ssh-key /etc/files_needed_for_tk/ansible_private_ssh_key --backup-dest +RECO --ora-swlib-path /u01/oracle_install --ora-version 19 --ora-swlib-type gcs --ora-asm-disks /etc/files_needed_for_tk/single-instance-asm.json --ora-data-mounts /etc/files_needed_for_tk/single-instance-data-mounts.json --cluster-type NONE --ora-data-destination DATA --ora-reco-destination RECO --ora-db-name orcl --ora-db-container true --instance-ip-addr 172.16.117.3 --instance-hostname g322234287-s002
...
Ansible params: 
Found Ansible: ansible-playbook is /usr/local/bin/ansible-playbook
No [primary]/[standby] groups found; running legacy flow.
Legacy flow -> ansible-playbook -i ./inventory_files/inventory_g322234287-s002_orcl   compatibility-tests.yml
[WARNING]: provided hosts list is empty, only localhost is available. Note that
the implicit localhost does not match 'all'
[WARNING]: Could not match supplied host pattern, ignoring: dbasm

PLAY [Check Linux Oracle Compatibility] ****************************************
skipping: no hosts matched

https://oss.gprow.dev/view/gs/gcp-oracle-prow-bucket/pr-logs/pull/google_oracle-toolkit/369/oracle-toolkit-install-rac-on-bms/1975649660420755456

./install-oracle.sh --ora-swlib-bucket gs://bmaas-testing-oracle-software --instance-ssh-user ansible --instance-ssh-key /etc/files_needed_for_tk/ansible_private_ssh_key --backup-dest +RECO --ora-swlib-path /u01/oracle_install --ora-version 19 --ora-swlib-type gcs --ora-asm-disks /etc/files_needed_for_tk/rac-asm.json --ora-data-mounts /etc/files_needed_for_tk/rac-data-mounts.json --cluster-type RAC --cluster-config /etc/files_needed_for_tk/rac-config.json --ora-data-destination DATA --ora-reco-destination RECO --ora-db-name orcl --ora-db-container false
...
nsible params: 
Found Ansible: ansible-playbook is /usr/local/bin/ansible-playbook
No [primary]/[standby] groups found; running legacy flow.
Legacy flow -> ansible-playbook -i ./inventory_files/inventory_orcl_RAC   compatibility-tests.yml
[WARNING]:  * Failed to parse /home/prow/go/src/github.com/google/oracle-
toolkit/inventory_files/inventory_orcl_RAC with yaml plugin: We were unable to
read either as JSON nor YAML, these are the errors we got from each: JSON:
Expecting value: line 1 column 2 (char 1)  Syntax Error while loading YAML.
found unexpected ':'  The error appears to be in
'/home/prow/go/src/github.com/google/oracle-
toolkit/inventory_files/inventory_orcl_RAC': line 1, column 7, but may be
elsewhere in the file depending on the exact syntax problem.  The offending
line appears to be:   [dbasm:vars]       ^ here
[WARNING]:  * Failed to parse /home/prow/go/src/github.com/google/oracle-
toolkit/inventory_files/inventory_orcl_RAC with ini plugin:
/home/prow/go/src/github.com/google/oracle-
toolkit/inventory_files/inventory_orcl_RAC:1: Section [dbasm:vars] not valid
for undefined group: dbasm

[pkaushik-pythian]

/retest

[AlexBasinov]

Hi,

Why is this function necessary?

The google-cloud-workload-agent.rpm installation already creates this directory to place the default configuration.json file within it.

Also, it appears the function is designed to run only when INSTALL_WORKLOAD_AGENT is not "true". what is the scenario in which this directory is required without the agent itself being installed?

[pkaushik-pythian]

Hey, it wasn’t necessary it was only added earlier because our presubmit tests were failing. Now that the tests have passed, I’ve removed it.