feat: Add proper version parsing mapping for TuxCare advisories#5296
Open
Korulag wants to merge 8 commits intogoogle:masterfrom
Open
feat: Add proper version parsing mapping for TuxCare advisories#5296Korulag wants to merge 8 commits intogoogle:masterfrom
Korulag wants to merge 8 commits intogoogle:masterfrom
Conversation
Signed-off-by: Vasily Kleschov <vkleschov@cloudlinux.com>
Member
|
Thanks for addressing this. I have concerns over the way this is being implemented as special logic just for handling TuxCare. something like class TuxCareEcosystem(OrderedEcosystem):
def __init__(self, suffix: str | None):
super().__init__(suffix)
# Lazy import to avoid circular dependency
from ._ecosystems import get
# Add the checks for TuxCare:TuxCare here
self._inner = get(suffix) if suffix else None
def _sort_key(self, version):
# check that _inner is set
return self._inner._sort_key(version)
# def coarse_version(...)Also, we're in the process of migrating stuff to go - could you also add a similar implementation to the equivalent go code |
Moved TuxCare ecosystem implementation into a separate file for Python part; Created corresponding Go implementation of the same thing. Signed-off-by: Vasily Kleschov <vkleschov@cloudlinux.com>
Signed-off-by: Vasily Kleschov <vkleschov@cloudlinux.com>
Contributor
Author
|
@michaelkedar could you please take a look again? I'm not sure about correctness of Go part, but Python one was reworked as you requested |
michaelkedar
previously approved these changes
May 6, 2026
Member
michaelkedar
left a comment
There was a problem hiding this comment.
Thanks! Happy to merge this.
Signed-off-by: Vasily Kleschov <vkleschov@cloudlinux.com>
Member
|
/gcbrun |
Signed-off-by: Vasily Kleschov <vkleschov@cloudlinux.com>
Contributor
Author
|
@michaelkedar I've fixed linting errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added changes to parse package versions properly if the ecosystem is TuxCare as per discussion in #4913