fix: make build tooling paths portable#1479
Open
KirtiRamchandani wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some repo build and test tooling assumes POSIX shell/path behavior. On Windows, that can break before the intended command runs:
prebuildusesrm -rf build.import.meta.urlwithnew URL(...).pathname, which produces invalid filesystem paths for Windows drive-letter paths.test:circularrelies on shell glob expansion forsrc/*.Root cause
URL pathnames are not filesystem paths on all platforms, and npm scripts should not depend on shell-specific cleanup or glob expansion for these commands.
Solution
fileURLToPath(import.meta.url)before passing module paths tonode:path.fs.rmSync(..., { recursive: true, force: true })through Node.srcdirectory with explicit TypeScript extensions.package.json.Tests
npm run build:versionsnpm run test:licensenpm run test:circularnpm run test:sizenode --checkon modified scripts/testsnpx prettier --check package.json docs\architecture.md scripts\build-js.mjs scripts\build-jsr.mjs scripts\build-pkgjson-lite.mjs scripts\build-pkgjson-main.mjs scripts\build-size-limit.mjs scripts\build-tests.mjs scripts\build-versions.mjs test\extra.test.js test\it\build-jsr.test.jsgit diff --check