-
Notifications
You must be signed in to change notification settings - Fork 346
chore: librarian release pull request: 20260126T120558Z #1947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated release preparation for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the google-auth library to version 2.49.0-dev0. The main changes involve refactoring the rsa library dependency. It has been moved from a core dependency to a conditional import within google/auth/crypt/rsa.py and is now primarily a test dependency. This is a positive step towards deprecating the rsa library in favor of cryptography, improving the library's overall maintainability and efficiency. The changelog and version file have also been updated accordingly.
I am having trouble creating individual review comments. Click here to see my feedback.
google/auth/crypt/rsa.py (27)
The removal of the top-level import for _python_rsa and its subsequent conditional import within the __init__ methods is a good practice. This defers the loading of the deprecated rsa library until it's actually needed, which can improve startup performance and reduce the core dependency footprint. This aligns with the goal of transitioning to cryptography.
google/auth/crypt/rsa.py (39)
Adding ImportError to the RSAVerifier docstring is important. Since _python_rsa is now conditionally imported, an ImportError could be raised if rsa.key.PublicKey is used without the rsa library being installed, providing clearer error handling for users.
google/auth/crypt/rsa.py (48-50)
The conditional import of _python_rsa here is a good way to manage the dependency on the deprecated rsa library. It ensures that the library is only loaded when the specific rsa.key.PublicKey type is encountered, minimizing its impact on the overall package.
google/auth/crypt/rsa.py (90)
Similarly, adding ImportError to the RSASigner docstring is crucial. With the conditional import of _python_rsa, users attempting to use rsa.key.PrivateKey without the rsa library installed will now receive a more informative error.
google/auth/crypt/rsa.py (99-101)
This conditional import for _python_rsa in RSASigner mirrors the change in RSAVerifier. It's a sensible approach to gradually phase out the rsa library while maintaining compatibility for existing code paths that still rely on it.
setup.py (28-30)
Removing the rsa library from the main DEPENDENCIES list is a good move, aligning with the deprecation warning in _python_rsa.py and promoting the use of cryptography. This reduces the primary dependency burden.
setup.py (73-75)
Moving the rsa dependency to testing_extra_require with a clear comment is an appropriate transitional step. It ensures that existing tests that rely on the rsa library can still function while the library is being phased out from core dependencies.
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.
Librarian Version: v0.8.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
google-auth: 2.49.0-dev0
2.49.0-dev0 (2026-01-26)
Features
honor
NO_GCE_CHECKenvironment variable (feat: honorNO_GCE_CHECKenvironment variable #1610) (383c9827)add configurable GCE Metadata Server retries (feat: add configurable GCE Metadata Server retries #1488) (454b441b)
add cryptography as required dependency (feat: add cryptography as required dependency #1929) (52558ae2)
Support the mTLS IAM domain for Certificate based Access (feat(iam): Support the mTLS IAM domain for Certificate based Access #1938) (8dcf91a1)
Bug Fixes
resolve circular imports (fix: resolve circular imports #1942) (25c1b064)
Use
user_verification=preferredfor ReAuth WebAuthn challenge (fix: Useuser_verification=preferredfor ReAuth WebAuthn challenge #1798) (3f88a240)removes
content-headerfrom AWS IMDS get request (fix: removescontent-headerfrom AWS IMDS get request #1934) (97bfea9e)detect correct auth when ADC env var is set but empty (fix: detect correct auth when ADC env var is set but empty #1374) (bfc07e10)
replace deprecated utcfromtimestamp (fix: replace deprecated utcfromtimestamp #1799) (e431f20c)