-
Notifications
You must be signed in to change notification settings - Fork 346
chore: librarian release pull request: 20260126T121420Z #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: librarian release pull request: 20260126T121420Z #1949
Conversation
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the release process for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, created automatically by the Librarian CLI, prepares a new release 2.49.0-dev0. The primary change is the removal of the hard dependency on the deprecated rsa library, making it an optional dependency. This is achieved through lazy loading of the module when it's needed. The implementation is sound and correctly updates the dependencies in setup.py and test configurations. My review identified a couple of minor stylistic issues related to extra blank lines, which I've provided suggestions for. Overall, the changes are excellent and improve the library's dependency management.
| from google.auth.crypt import _python_rsa | ||
|
|
||
| impl_lib = _python_rsa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extra blank line on line 49 is unnecessary and violates PEP 8's guidance on vertical whitespace. Removing it will make the code more compact and consistent.
| from google.auth.crypt import _python_rsa | |
| impl_lib = _python_rsa | |
| from google.auth.crypt import _python_rsa | |
| impl_lib = _python_rsa |
References
- PEP 8 (E303) advises against using too many blank lines. Extra blank lines should be used sparingly to indicate logical sections, which is not the case here. (link)
| from google.auth.crypt import _python_rsa | ||
|
|
||
| impl_lib = _python_rsa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the other change in this file, the extra blank line on line 100 is unnecessary and violates PEP 8's guidance on vertical whitespace. It should be removed for consistency.
| from google.auth.crypt import _python_rsa | |
| impl_lib = _python_rsa | |
| from google.auth.crypt import _python_rsa | |
| impl_lib = _python_rsa |
References
- PEP 8 (E303) advises against using too many blank lines. Extra blank lines should be used sparingly to indicate logical sections, which is not the case here. (link)
|
Adding |
977ec3c
into
development-build-v2.49.0.dev0
|
|
I think Librarian took this pull request based on some criteria (maybe |
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.
Librarian Version: v0.8.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
google-auth: 2.49.0-dev0
2.49.0-dev0 (2026-01-26)
Bug Fixes