ci(bigtable): use full location name for clusters in table_admin_integration_test

[scotthart]

Post table admin API changes, the WaitForConsistencyCheck test was not specifying the full location name when creating clusters.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical regression in the WaitForConsistencyCheck integration test for Google Cloud Bigtable. Following recent API changes, the test was failing because it did not specify the full location name when creating clusters. The changes ensure that cluster configurations correctly use the complete location identifiers, thereby restoring the test's functionality and ensuring proper validation of Bigtable's consistency checks.

Highlights

• Test Fix: The WaitForConsistencyCheck integration test was updated to correctly specify the full location name when creating Bigtable clusters, resolving a regression introduced by recent API changes.
• Dependency Updates: New headers google/cloud/location/locations.pb.h and google/cloud/location.h were included to support the use of full location names.
• Code Refinement: The test now explicitly constructs Location objects and uses their FullName() method when defining bigtable::ClusterConfig instances.

Changelog

• google/cloud/bigtable/tests/table_admin_integration_test.cc
  • Added includes for google/cloud/location/locations.pb.h and google/cloud/location.h.
  • Introduced a using declaration for google::cloud::bigtable::testing::TableTestEnvironment to simplify code.
  • Modified the WaitForConsistencyCheck test to construct Location objects using project and zone information.
  • Updated bigtable::ClusterConfig creation to use the FullName() of the newly constructed Location objects.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the WaitForConsistencyCheck integration test to use the full location name when creating clusters, which is now required. I've included one suggestion to make the code for creating cluster configurations more concise.

[gemini-code-assist]

To improve conciseness and avoid repeating Project(TableTestEnvironment::project_id()), you could create a project variable and then construct the ClusterConfig objects directly without intermediate location_1 and location_2 variables.

  auto const project = Project(TableTestEnvironment::project_id());
  auto cluster_config_1 = bigtable::ClusterConfig(
      Location(project, TableTestEnvironment::zone_a()).FullName(), 3,
      bigtable::ClusterConfig::HDD);
  auto cluster_config_2 = bigtable::ClusterConfig(
      Location(project, TableTestEnvironment::zone_b()).FullName(), 3,
      bigtable::ClusterConfig::HDD);

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.65%. Comparing base (00bbbd6) to head (4f6d4a1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16036      +/-   ##
==========================================
- Coverage   92.65%   92.65%   -0.01%     
==========================================
  Files        2339     2339              
  Lines      215282   215286       +4     
==========================================
+ Hits       199470   199472       +2     
- Misses      15812    15814       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.