fix: remove deprecated ATOMIC_VAR_INIT usage#16127
Open
faximan wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates google/cloud/internal/future_impl.h to initialize the cancelled_ atomic boolean using direct list initialization ({false}) instead of the deprecated ATOMIC_VAR_INIT macro. There are no review comments, and I have no additional feedback to provide.
The `ATOMIC_VAR_INIT` macro was deprecated in C++20 and removed in C++23.
Since `google-cloud-cpp` v3 targets C++17 or newer, we can safely replace it
with standard brace initialization `std::atomic<bool> cancelled_{false}`.
This resolves compilation failures in projects that consume `google-cloud-cpp`
headers with C++20 enabled and strict warning settings (like `-Werror`
combined with `-Wdeprecated-pragma`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ATOMIC_VAR_INITmacro was deprecated in C++20 and removed in C++23. Since v3 targets C++17 or newer, we can safely replace it with standard brace initializationstd::atomic<bool> cancelled_{false}.This resolves compilation failures in projects that use this project with C++20 enabled and strict warning settings (like
-Werrorcombined with-Wdeprecated-pragma).It seems this is the only usage of
ATOMIC_VAR_INITin the repo.