Skip to content

test(gax): Error Logging Integration Test#12329

Open
westarle wants to merge 3 commits intogoogleapis:mainfrom
westarle:test/actionable-errors-logging-integration
Open

test(gax): Error Logging Integration Test#12329
westarle wants to merge 3 commits intogoogleapis:mainfrom
westarle:test/actionable-errors-logging-integration

Conversation

@westarle
Copy link
Copy Markdown
Contributor

@westarle westarle commented Mar 31, 2026

Add an automated integration test (ITActionableErrorsLogging) to ensure end-to-end functionality of the Actionable Errors logging framework against a livegapic-showcase server.

  • Integration Test Implementation: Added ITActionableErrorsLogging to verify that LoggingTracer correctly extracts and emits google.rpc.ErrorInfo context (reason, domain, and metadata) as structured DEBUG logs during failed attempts.
  • Reflection-Free Execution: Completely eliminated Java reflection and explicit Logback casting. The test now relies on the standard TestLogger and TestServiceProvider implementation provided by gax-testlib.
  • Build Configuration: Updated gax and gapic-showcase pom.xml files to correctly expose META-INF/services/** and include the test exclusively when the -PenvVarTest profile is
    activated.
  • Transport Coverage: Includes tests for both gRPC and HTTP/JSON transports (using a MockHttpTransport to simulate the correct JSON error payload for REST).

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces integration tests for actionable error logging in both gRPC and HTTP/JSON transports, along with necessary build configuration updates in the GAX and Showcase modules. The changes include a new Maven profile for running environment-specific tests and the addition of the ITActionableErrorsLogging test suite. Review feedback focuses on narrowing the scope of included service providers in the POM to avoid bundling unnecessary files, centralizing dependency version management, removing unused imports and variables, and ensuring proper resource cleanup by calling awaitTermination after closing clients in tests.

@westarle westarle force-pushed the test/actionable-errors-logging-integration branch 5 times, most recently from ed93f27 to c791c8f Compare April 2, 2026 15:57
@westarle westarle force-pushed the test/actionable-errors-logging-integration branch 2 times, most recently from 8168c9e to a91b77b Compare April 2, 2026 18:57
@westarle westarle marked this pull request as ready for review April 2, 2026 19:01
@westarle westarle requested a review from a team as a code owner April 2, 2026 19:01
@westarle westarle force-pushed the test/actionable-errors-logging-integration branch from a91b77b to d98fd2a Compare April 2, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant