fix(gax): Implement lazy resource name evaluation in ApiTracerContext#12618
Merged
fix(gax): Implement lazy resource name evaluation in ApiTracerContext#12618
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the destination resource ID handling in ApiTracerContext to support lazy evaluation via a Supplier, which improves performance and flexibility. The changes include updating the Builder API and migrating existing usages to the new supplier-based approach. I have provided a suggestion to maintain backward compatibility by keeping the original setDestinationResourceId method as a convenience wrapper. The second review comment was removed as it was a general observation without an actionable code suggestion.
sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/ApiTracerContext.java
Show resolved
Hide resolved
blakeli0
changed the title
diegomarquezp
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
TracedUnaryCallabletoApiTracerContext. This ensures that the extraction is done lazily only when resource name is needed in tracing. Hence it does not affect regular customers at all if tracing is not enabled.