Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies the generation_config.yaml file to downgrade the gapic_generator_version from 2.68.0 to 2.67.0. The reviewer has flagged this change as a potential risk, noting that downgrading dependencies is generally discouraged due to the possibility of reintroducing bugs or security vulnerabilities, and has provided a suggestion to revert the version to 2.68.0.
| @@ -1,4 +1,4 @@ | |||
| gapic_generator_version: 2.68.0 | |||
| gapic_generator_version: 2.67.0 | |||
There was a problem hiding this comment.
The gapic_generator_version is being downgraded from 2.68.0 to 2.67.0. Downgrading a dependency version is generally not recommended as it can reintroduce old bugs or security vulnerabilities. Please revert this change unless the downgrade is intentional and necessary to fix a specific issue with the newer version.
gapic_generator_version: 2.68.0
BEGIN_COMMIT_OVERRIDE
BEGIN_NESTED_COMMIT
fix(deps): update the Java code generator (gapic-generator-java) to 2.67.0
END_NESTED_COMMIT
END_COMMIT_OVERRIDE