test(bigquery): Fix flaky ITBigQueryTest#testProjectIDFastSQLQueryWithJobId#12675
Merged
jinseopkim0 merged 2 commits intomainfrom Apr 3, 2026
Merged
test(bigquery): Fix flaky ITBigQueryTest#testProjectIDFastSQLQueryWithJobId#12675jinseopkim0 merged 2 commits intomainfrom
jinseopkim0 merged 2 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the error handling assertions in ITBigQueryTest.java to verify the HTTP status code and improve the flexibility of the exception message check. The review highlights a potential false positive due to the missing failure trigger in the try-catch block and suggests narrowing the assertion condition to be more specific to the expected error.
...igquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
Show resolved
Hide resolved
...igquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Apr 3, 2026
...igquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
Show resolved
Hide resolved
lqiu96
approved these changes
Apr 3, 2026
…hJobId This PR fixes a flaky integration test by replacing a strict string assertion on a backend error message with a more robust assertion on the HTTP status code (400 Bad Request). It also refactors the test to use JUnit's \`assertThrows\` for cleaner and more idiomatic exception testing, automatically preventing false positives if the exception isn't thrown. Fixes #12135
lqiu96
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a flaky integration test by replacing a strict string assertion
on a backend error message with a more robust assertion on the HTTP status
code (400 Bad Request).
It also refactors the test to use JUnit's `assertThrows` for cleaner and
more idiomatic exception testing, automatically preventing false positives
if the exception isn't thrown.
Fixes #12135