Skip to content

test(auth): Assert IOException on invalid or malformed private keys #13486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
westarle wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Draft

test(auth): Assert IOException on invalid or malformed private keys #13486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions google-auth-library-java/oauth2_http/javatests/com/google/auth/oauth2/OAuth2UtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,20 @@
/** Tests for {@link OAuth2Utils}. */
class OAuth2UtilsTest {

@Test
void testPrivateKeyFromPkcs8_invalidKey() {
String invalidKey = "-----BEGIN PRIVATE KEY-----\n" +
"INVALID_KEY_DATA\n" +
"-----END PRIVATE KEY-----\n";
assertThrows(java.io.IOException.class, () -> OAuth2Utils.privateKeyFromPkcs8(invalidKey));

@gemini-code-assist gemini-code-assist Bot Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid using the fully qualified class name java.io.IOException.class. It is cleaner and more idiomatic to import java.io.IOException and use IOException.class directly.

Suggested change
assertThrows(java.io.IOException.class, () -> OAuth2Utils.privateKeyFromPkcs8(invalidKey));
assertThrows(IOException.class, () -> OAuth2Utils.privateKeyFromPkcs8(invalidKey));

}

@Test
void testPrivateKeyFromPkcs8_malformedPem() {
String malformedKey = "just some random string";
assertThrows(java.io.IOException.class, () -> OAuth2Utils.privateKeyFromPkcs8(malformedKey));

@gemini-code-assist gemini-code-assist Bot Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid using the fully qualified class name java.io.IOException.class. It is cleaner and more idiomatic to import java.io.IOException and use IOException.class directly.

Suggested change
assertThrows(java.io.IOException.class, () -> OAuth2Utils.privateKeyFromPkcs8(malformedKey));
assertThrows(IOException.class, () -> OAuth2Utils.privateKeyFromPkcs8(malformedKey));

}

@Test
void testValidCredentials() {
String username = "testUser";
Expand Down
Loading