Skip to content

ci: Do not run the autogenerated GAPICs unit tests #13495

Draft
lqiu96 wants to merge 3 commits into
mainfrom
disable-generated-tests
Draft

ci: Do not run the autogenerated GAPICs unit tests #13495
lqiu96 wants to merge 3 commits into
mainfrom
disable-generated-tests

Conversation

@lqiu96

@lqiu96 lqiu96 commented Jun 16, 2026

Copy link
Copy Markdown
Member

Part of #13296

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a configuration in the parent POM to exclude generated client unit tests directly under versioned packages from the Maven Surefire plugin to optimize CI execution time, while allowing specific modules like google-cloud-bigquerystorage to override this behavior. However, nesting the comma-separated property ${surefire.excludes} inside an tag prevents Maven from splitting the patterns correctly, making the exclusion ineffective. It is recommended to pass the property directly to the element instead.

Comment on lines +229 to +231
<excludes>
<exclude>${surefire.excludes}</exclude>
</excludes>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In Maven, when a plugin parameter is of type List (like excludes in maven-surefire-plugin), nesting a comma-separated property inside an <exclude> tag prevents Maven from splitting the string. It treats the entire comma-separated value as a single literal pattern containing a comma, which will fail to match any files and render the exclusion ineffective.

To allow Maven to correctly split the comma-separated property ${surefire.excludes} into individual list elements, pass the property directly to the <excludes> element.

          <excludes>${surefire.excludes}</excludes>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant