chore(java-cloud-bom): migrate java-cloud-bom into monorepo#13498
chore(java-cloud-bom): migrate java-cloud-bom into monorepo#13498jinseopkim0 wants to merge 7 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates the java-cloud-bom module into the monorepo, introducing BOM configurations, validation tests, a dashboard generator, and release-note utilities. The code review identified several critical issues that need to be addressed: a missing comma in a Python list in updateREADMETable.py causing implicit string concatenation, multiple unclosed file streams in ArtifactMavenData.java and DashboardMain.java leading to resource leaks, a potential deadlock in ReleaseNoteGeneration.java when reading process streams, and missing explicit UTF-8 encoding specifications in both Java and Python file operations.
jinseopkim0
force-pushed
the
migrate-java-cloud-bom
branch
2 times, most recently
from
546fe09 to
6f9b129
Compare
jinseopkim0
force-pushed
the
migrate-java-cloud-bom
branch
from
6f9b129 to
209f419
Compare
… fix dependency convergence
…ation POMs to fix global execution failures
…id unresolvable gapic-libraries-bom in subdirectory builds
|
|
1 participant
b/477663818