perf(Spanner): Eliminate extend overhead#8865
Open
alkatrivedi wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the external extend dependency with native Object.assign and explicit property assignments across various source and test files in the Spanner client library. The reviewer feedback is highly constructive, suggesting the complete elimination of the remaining extend deep copies by using shallow copies with Object.assign where safe. Additionally, the reviewer points out several redundant type assertions (such as casting gaxOpts and reqOpts) that can be removed to simplify and clean up the conditional property assignments.
22cce10 to
6fb792b
Compare
6fb792b to
2900512
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing unnecessary overhead from the extend dependency where simple shallow merges are sufficient to reduce CPU ticks and improvement in the performance of node client