testing only - regenerating bigtable with legacylibrarian#16709
testing only - regenerating bigtable with legacylibrarian#16709jskeet wants to merge 2 commits intogoogleapis:mainfrom
Conversation
jskeet
added
the
do not merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the Edition enum and field to Bigtable instances and adds a locations field to the AutomatedBackupPolicy. It also updates documentation for backup retention and frequency. Several types, including ProtoRows, FeatureFlags, PeerInfo, and ResponseParams, have been removed from the public API. The review feedback highlights that these removals are breaking changes requiring a minor version bump and identifies a typo in the AutomatedBackupPolicy docstring.
| Mutation, | ||
| PartialResultSet, | ||
| ProtoFormat, | ||
| ProtoRows, |
There was a problem hiding this comment.
The removal of ProtoRows, FeatureFlags, PeerInfo, and ResponseParams from the public API is a breaking change. If this is intentional, please ensure that a minor version bump is performed rather than a patch, in accordance with the rule that breaking changes require a minor version bump to maintain support for older environments.
References
- When a release introduces breaking changes, prefer a minor version bump over a patch version bump to maintain the ability to provide patches for the previous minor version.
| backups will be created in all zones of the instance. | ||
| Locations are in the format | ||
| ``projects/{project}/locations/{zone}``. This field can only | ||
| set for tables in Enterprise Plus instances. |
There was a problem hiding this comment.
There is a typo in the docstring: 'can only set' should be 'can only be set'.
| set for tables in Enterprise Plus instances. | |
| be set for tables in Enterprise Plus instances. |
1 participant
No description provided.