[DRAFT] feat(auth): allow single-string scopes for google.auth.default#16787
Draft
daniel-sanche wants to merge 10 commits intomainfrom
Draft
[DRAFT] feat(auth): allow single-string scopes for google.auth.default#16787daniel-sanche wants to merge 10 commits intomainfrom
daniel-sanche wants to merge 10 commits intomainfrom
Conversation
daniel-sanche
changed the title
daniel-sanche
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces type hints and updates function signatures to support single-string scopes in addition to sequences of strings across several modules, including _default.py, app_engine.py, and credentials.py. The review feedback correctly identifies a compatibility issue where the | union operator is used; since this library supports Python versions older than 3.10, these instances must be replaced with typing.Union to avoid runtime errors. Additionally, consistency between function signatures and docstrings regarding type union syntax was requested.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were having trouble importing this library into google3, because a lot of internal usages were passing single strings in as scopes, and the type checker would fail
This PR changes the type support to allow what the internal users are already doing
Also clean up some other types that were inconsistent or caused issues with google3