chore: remove all explicit transport options#16789
Conversation
This does not create any differences after regeneration.
There was a problem hiding this comment.
Code Review
This pull request removes explicit transport configuration settings for numerous Google Cloud APIs within the librarian.yaml file. The review feedback suggests that these changes introduce fragility into the build process by relying on the generator's inference logic rather than explicit definitions. This is particularly concerning for APIs with specific transport requirements, such as those that are REST-only or gRPC-only, and maintaining these explicit settings is recommended for robustness and clarity.
| google/cloud/bigquery/datapolicies/v1: | ||
| - python-gapic-namespace=google.cloud | ||
| - python-gapic-name=bigquery_datapolicies | ||
| - transport=grpc+rest |
There was a problem hiding this comment.
While the goal of reducing configuration is understandable, removing explicit transport settings across the file makes the build process more fragile. It relies on the generator's ability to correctly infer the transport for each of the many API versions.
This is particularly risky for APIs with non-standard transports, for example:
google/cloud/compute/v1which isrest-only (line 1361).- Several
betaversions which aregrpc-only, while theirv1counterparts aregrpc+rest(e.g., line 996).
If the generator's inference logic changes in the future, it could silently introduce incorrect transport support. Explicitly defining the transport is more robust and self-documenting. It is recommended to revert these changes to maintain explicitness and reduce future maintenance risks.
This does not create any differences after regeneration (because the options are all inferred correctly).