Skip to content

chore: remove description_override from librarian.yaml#16796

Open
jskeet wants to merge 4 commits intogoogleapis:mainfrom
jskeet:remove-description-override
Open

chore: remove description_override from librarian.yaml#16796
jskeet wants to merge 4 commits intogoogleapis:mainfrom
jskeet:remove-description-override

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 24, 2026

@jskeet jskeet requested a review from daniel-sanche April 24, 2026 10:41
@jskeet jskeet requested review from a team as code owners April 24, 2026 10:41
@jskeet jskeet requested review from TrevorBergeron and removed request for a team April 24, 2026 10:41
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a large-scale cleanup by removing description_override fields from librarian.yaml and updating API descriptions across numerous Google Cloud library packages. While many updates standardize the metadata, a regression was identified where some libraries, such as google-apps-card, now have empty descriptions in their documentation because the source metadata was removed without a replacement.

|preview| |pypi| |versions|

`Google Apps Card Protos`_: Google Apps Card Protos
`Google Apps Card Protos`_:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The library description is now empty. This occurs because the description was removed from both librarian.yaml and .repo-metadata.json without providing a replacement. This results in a regression in the generated documentation. Please ensure that a valid description is available (e.g., in .repo-metadata.json or the source proto files) so that the README is correctly populated. This issue affects many other packages in this PR (e.g., google-area120-tables, google-cloud-compute, google-cloud-deploy).

@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Apr 24, 2026

As per product_documentation_override, where values are now missing for generated libraries, we can add a description value into sdk.yaml. I'll come up with a PR for that in a little while.

@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Apr 24, 2026

Packages where I believe we need to add a description to sdk.yaml:

  • google-apps-card
  • google-area120-tables
  • google-cloud-alloydb-connectors
  • google-cloud-api-gateway
  • google-cloud-apigee-connect
  • google-cloud-apigee-registry
  • google-cloud-apihub
  • google-cloud-apphub
  • google-cloud-assured-workloads
  • google-cloud-backupdr
  • google-cloud-certificate-manager
  • google-cloud-cloudsecuritycompliance
  • google-cloud-common
  • google-cloud-compute-v1beta
  • google-cloud-compute
  • google-cloud-contact-center-insights
  • google-cloud-datacatalog-lineage
  • google-cloud-datastream
  • google-cloud-deploy
  • google-cloud-edgecontainer
  • google-cloud-essential-contacts
  • google-cloud-financialservices
  • google-cloud-gdchardwaremanagement
  • google-cloud-geminidataanalytics
  • google-cloud-gke-hub
  • google-cloud-gsuiteaddons
  • google-cloud-kms-inventory
  • google-cloud-locationfinder
  • google-cloud-lustre
  • google-cloud-media-translation
  • google-cloud-memorystore
  • google-cloud-parallelstore
  • google-cloud-phishing-protection
  • google-cloud-policy-troubleshooter
  • google-cloud-recommender
  • google-cloud-storagebatchoperations
  • google-cloud-video-live-stream
  • google-cloud-video-stitcher
  • google-cloud-visionai
  • google-cloud-webrisk

@jskeet jskeet requested a review from parthea April 24, 2026 16:20
@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Apr 24, 2026

@parthea: I'm not expecting us to be able to do this one today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant